feat: set flags based on biome-version to add backwards compatibility #96
+41
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I must admit that this is an awkward setting, probably because at that time the LSP didn't support the majority of the endpoints. This check shouldn't be needed, however I know nothing about intellij extension developments, so I hope this will be removed in the future |
ematipico
approved these changes
Sep 25, 2024
ematipico
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Biome v1.8.0 the cli arguments have changed from
--applyand--apply-unsafeto--writeand--unsafe.In #85 we updated the cli flags, but dropped backwards compatibility.
This PR checks the running biome version to add backwards compatibility to biome prior to 1.8.0. This PR also sets
--skip-errorsto skip files containing syntax errors instead of throw an error.Fixes #89 #90 #95